feat: upgrading colours & font in wave 2.0 | SUP-49317 #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mukesh-FN
requested review from
jonotrujillo and
dornelasnelson
as code owners
commit: |
Mukesh-FN
force-pushed
the
SUP-49317/color-and-font-upgrade-for-brand-evolutions
branch
from
40b8ff8 to
fedf564
Compare
lloydaf
reviewed
Aug 21, 2025
| 80: 'hsl(122, 24%, 73%)', | ||
| 90: 'hsl(124, 24%, 87%)', | ||
| 95: 'hsl(120, 24%, 93%)', | ||
| 97: 'hsl(120, 20%, 97%)' |
There was a problem hiding this comment.
I see that we are removing a lot of colours that we added recently(?), did something change or do we not need them anymore?
There was a problem hiding this comment.
There has been some confusion regarding whether to adopt the 10–97 range or continue using the existing range (100–1100). After discussing with the Design Team, they have shared a new color set (link attached in the ticket) for the Wave 2.0 Classic and Modern themes for the old color range (100 - 1100). So now if you are using bare color you can use as it is without changing any code.
lloydaf
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SUP-49317
Upgrading font family and colours in wave 2.0 for brand evolution as per this design document.