test: use ES modules in codemods tests #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martimalek
requested review from
nlopin,
div-Leo and
jonotrujillo
as code owners
nlopin
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use ES modules in codemods tests instead of CommonJS
Why:
The codemods tests were using CommonJS modules without any export, if I'm not wrong this makes the file not act as a module but as part of the global scope, since we had the same import in each file to test
jscodeshiftcodemods they ended up conflicting with one another (see media section).
How:
requireforimportin each codemod test file
Media:
The issue:
You can check the entire job log if you prefer
Checklist: