Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email text/plain part #297

Merged
merged 2 commits into from
Aug 2, 2014
Merged

Conversation

sim6
Copy link
Contributor

@sim6 sim6 commented Jul 17, 2014

Fix #273

@tonylampada
Copy link
Member

Can one of the admins verify this patch?

@sim6 sim6 mentioned this pull request Jul 17, 2014
@tonylampada
Copy link
Member

add to whitelist

@tonylampada
Copy link
Member

Test PASSed.
Refer to this link for build results: http://jenkins.freedomsponsors.org/job/FreedomSponsors/255/

@tonylampada
Copy link
Member

@sim6 please bear with me for a while, I'm on a crazy week so it may take a while before I can review your PR's.

But I will

@sim6
Copy link
Contributor Author

sim6 commented Jul 17, 2014

@tonylampada No problem, thanks for your feedback.

@iurisilvio
Copy link
Contributor

The PR is really simple and looks good (I didn't tested it, just checked the code). 👍

I suggest you set the html2text version in requirements file to avoid unexpected updates.

I'm not sure if it is the case, but you can change the send_html_mail to create the text version if it is not defined.

@tonylampada
Copy link
Member

Test PASSed.
Refer to this link for build results: http://jenkins.freedomsponsors.org/job/FreedomSponsors/256/

@sim6
Copy link
Contributor Author

sim6 commented Jul 21, 2014

@iurisilvio thanks!

I added the html2text version in requirements file to avoid unexpected updates.

About send_html_mail, with this pull request I only want fix #273. Maybe we can modify the send mail method with other pull request. In this new pull request we can rewrite send_html_mail and plain_send_mail too, because plain_send_mail uses send_html_mail and sends a text/html part and text/plain with the same content. I think we can white new method that sends text/plain and text/html on demand.

@iurisilvio
Copy link
Contributor

👍

@tonylampada
Copy link
Member

I didn't tested it...

Well I did. It works great. :-)

Thanks @sim6!

tonylampada added a commit that referenced this pull request Aug 2, 2014
@tonylampada tonylampada merged commit 5e76f50 into freedomsponsors:master Aug 2, 2014
@sim6
Copy link
Contributor Author

sim6 commented Aug 2, 2014

:) Thank you!

@sim6 sim6 deleted the email-text-plain branch August 2, 2014 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send emails as plaintext
3 participants