Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly URL for user profile #209

Closed
tonylampada opened this issue Oct 8, 2013 · 4 comments
Closed

Friendly URL for user profile #209

tonylampada opened this issue Oct 8, 2013 · 4 comments
Assignees

Comments

@tonylampada
Copy link
Member

User profile URLs have the user id in it, like: http://freedomsponsors.org/core/user/2/tonylampada

It would be better to use something like:
http://freedomsponsors.org/user/tonylampada

This will have a few impacts:

  • UserInfo.screenName will have to be copied to Use.username
  • But we must make sure that it's a valid username first.
  • We must also make sure that it's unique
  • And me must give the current users a time window to change it (it will be immutable after that
  • After that we delete screenName from the db.
@tonylampada tonylampada self-assigned this Aug 22, 2014
@tonylampada
Copy link
Member Author

I'm starting this:

  • Create a way for users to change username, once.
  • Create a task that:
    • Copies UserInfo.screenName to Use.username (removing invalid characters / and de-duplicating if needed)
    • Send an email to users explaining that their usernames have been changed and why, and how it's gonna work. Explain they have 3 months to do so. Then point them the URL where they can change it if they want. Once.
    • When there 15 days left, need to send another email reminding the users who didn't.
  • Replace all usages of screenName for username
  • Refactor user creation/edition accordingly
  • 3 months later, disable the feature.

tonylampada added a commit that referenced this issue Aug 28, 2014
tonylampada added a commit that referenced this issue Aug 29, 2014
tonylampada added a commit that referenced this issue Aug 29, 2014
tonylampada added a commit that referenced this issue Aug 29, 2014
tonylampada added a commit that referenced this issue Aug 29, 2014
tonylampada added a commit that referenced this issue Aug 30, 2014
tonylampada added a commit that referenced this issue Aug 30, 2014
tonylampada added a commit that referenced this issue Aug 31, 2014
tonylampada added a commit that referenced this issue Aug 31, 2014
tonylampada added a commit that referenced this issue Aug 31, 2014
tonylampada added a commit that referenced this issue Aug 31, 2014
tonylampada added a commit that referenced this issue Sep 1, 2014
tonylampada added a commit that referenced this issue Sep 3, 2014
tonylampada added a commit that referenced this issue Sep 3, 2014
@tonylampada
Copy link
Member Author

I have a feeling this branch is ready to go. I'll just feel like I need to add a few more tests to it.

tonylampada added a commit that referenced this issue Sep 3, 2014
tonylampada added a commit that referenced this issue Sep 4, 2014
@tonylampada
Copy link
Member Author

After a few hiccups, all the necessary data migrations were ran, and (almost) all necessary emails were sent. This is almost done...

@tonylampada
Copy link
Member Author

OK, now it's done. Doesn't look like much, but this has annoyed for a long time, I'm glad I finally did this :-)

People are already changing their usernames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@tonylampada and others