Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues count is wrong in stats #114

Open
iurisilvio opened this issue Dec 26, 2012 · 7 comments
Open

Issues count is wrong in stats #114

iurisilvio opened this issue Dec 26, 2012 · 7 comments

Comments

@iurisilvio
Copy link
Contributor

The issues count ignores feedback sponsored issues (like #86).

@henriquebastos
Copy link
Contributor

I spotted that during a refactoring. What would be the correct query?

On Wednesday, December 26, 2012, Iuri de Silvio wrote:

The issues count ignores feedback sponsored issues (like #86#86
).


Reply to this email directly or view it on GitHubhttps://github.com//issues/114.

Henrique Bastos http://henriquebastos.net

Curso Welcome to the Django http://welcometothedjango.com.br
Aprenda Python e Django na Prática!

Twitter: @henriquebastos http://twitter.com/henriquebastos
Skype: henriquebastos.net
+55 21 9618-6180

@iurisilvio
Copy link
Contributor Author

Check line 15 in issue_service.py: https://github.com/freedomsponsors/www.freedomsponsors.org/blob/master/djangoproject/core/services/issue_services.py#L15

This was the same query you should have in stats, but it was changed to include feedback issues with offers.

@henriquebastos
Copy link
Contributor

@iurisilvio can you point us to the url where we can verify this behavior? Also, if you know what code snippet is responsible for the query, it would be very helpful to point it here.

@iurisilvio
Copy link
Contributor Author

I don't have an URL to help you. It happens only in stats page. Before PR #88, sponsored feedbacks weren't shown in home issues list.

To test it, add a feedback and an offer to this feedback issue. The sponsored issues count should be 1, but with the current query, it is 0.

@henriquebastos
Copy link
Contributor

Got it! The query is actually counting "sponsored issues" instead of all
issues.

I'll fix this on my stats PR.

@henriquebastos
Copy link
Contributor

The PR 120
already fix this.

@tonylampada, please, when you merge it, check this problem and update the
issue.

Henrique Bastos http://henriquebastos.net

Curso Welcome to the Django http://welcometothedjango.com.br
Aprenda Python e Django na Prática!

Twitter: @henriquebastos http://twitter.com/henriquebastos
Skype: henriquebastos.net
+55 21 9618-6180

On Thu, Jan 3, 2013 at 10:00 AM, FreedomSponsors Comments <
notifications@github.com> wrote:

Sponsor this issue on FreedomSponsors.orghttp://www.freedomsponsors.org/core/issue/sponsor?trackerURL=#114


Reply to this email directly or view it on GitHubhttps://github.com//issues/114#issuecomment-11841533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@henriquebastos @iurisilvio and others