Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust to 1.84.0, rustup to 1.27.1 #7423

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update rust to 1.84.0, rustup to 1.27.1 #7423

merged 2 commits into from
Jan 23, 2025

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #7408.

  • updates Rust toolchain to 1.84.0
  • updates rustup version to 1.27.1 (our version was getting long in the tooth)
  • fixes some lint catches

Testing

  • version updated correctly.
  • CI is passing.
  • make build-debs passes locally

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner January 23, 2025 01:05
@zenmonkeykstop zenmonkeykstop added this to the SecureDrop 2.12.0 milestone Jan 23, 2025
@legoktm legoktm self-assigned this Jan 23, 2025
legoktm
legoktm reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion inline, otherwise it looks good

redwood/Cargo.toml Show resolved Hide resolved
@legoktm
Copy link
Member

legoktm commented Jan 23, 2025

Looks good, I re-pushed it to a stg- branch just to make sure staging CI passes too (actually tests the compiled Rust code).

legoktm
legoktm approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, staging CI passed (except unrelated failures)

@legoktm legoktm added this pull request to the merge queue Jan 23, 2025
@legoktm legoktm added the Rust Issues that touch Rust code label Jan 23, 2025
Merged via the queue into develop with commit 034b834 Jan 23, 2025
66 of 67 checks passed
@legoktm legoktm deleted the 7408-rust-bump branch February 3, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legoktm legoktm legoktm approved these changes

Assignees

@legoktm legoktm

Labels
Rust Issues that touch Rust code
Projects
SecureDrop dev cycle
Status: Done
Milestone
SecureDrop 2.12.0
Development

Successfully merging this pull request may close these issues.

Upgrade Rust toolchain to 1.84.0
2 participants
@zenmonkeykstop @legoktm