Update openssl crate for RUSTSEC-2023-0072 #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't failing on unsound advisories, like the openssl crate's RUSTSEC-2023-0072.
sequoia-openpgp doesn't actually use the vulnerable `X509StoreRef::objects` function, but it's a pretty straightforward upgrade with no auditing required so let's do it.
> warning: virtual workspace defaulting to `resolver = "1"` despite one > or more workspace members being on edition 2021 which implies > `resolver = "2"` > note: to keep the current resolver, specify `workspace.resolver = "1"` > in the workspace root's manifest > note: to use the edition 2021 resolver, specify `workspace.resolver = > "2"` in the workspace root's manifest > note: for more details see https://doc.rust-lang.org/cargo/reference/ > resolver.html#resolver-versions So just set resolver = "2" in the root Cargo.toml, as instructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Testing
How should the reviewer test this PR?
make rust-auditis cleanDeployment
Any special considerations for deployment? No
Checklist
make lint) and tests (make test) pass in the development container