Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CI job for app tests on Focal #5619

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Add new CI job for app tests on Focal #5619

merged 1 commit into from
Nov 10, 2020

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Nov 9, 2020

Status

Ready for review

Description of Changes

Fixes #5524

This adds related CI steps for app tests on Focal

Testing

  • CI should have a new job for app tests on Focal.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@kushaldas kushaldas force-pushed the focal_ci branch 2 times, most recently from c42f4aa to f2dd714 Compare November 9, 2020 13:26
This adds related CI steps for app tests on Focal
@eloquence eloquence changed the title Fixes #5524 New CI job for app tests on Focal Add new CI job for app tests on Focal Nov 9, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is passing and the docker caching is working in CI. LGTM

@@ -51,6 +51,49 @@ common-steps:
paths:
- /caches/layers.tar

- &focalcreatecachedir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably re-use the same cache dir as for Xenial just specifying different layer files

@emkll emkll merged commit a7fb46a into develop Nov 10, 2020
@emkll emkll deleted the focal_ci branch November 10, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI job to run Securedrop application tests on Focal using Python3.8
2 participants