Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey-patch pretty-bad-protocol to work with Focal gnupg #5615

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Nov 4, 2020

Status

Ready for review

Description of Changes

Fixes #5592.

To work with recent gnupg, the pretty-bad-protocol package needs an update it seems unlikely to get, so we're gonna monkey-patch it until we can find a viable replacement.

isislovecruft/python-gnupg#250

Testing

  • CI should be green.
  • make test-focal should pass.
  • In the source interface, submit a message and a file.
  • Confirm that you can download those from the journalist interface and decrypt them.
  • Send a reply to the source, and confirm that it's readable in the source interface.

Deployment

This modifies the unmaintained library we're using for encrypting submissions and replies so that it will work on Focal. It shouldn't negatively affect Xenial.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

To work with recent gnupg, the pretty-bad-protocol package needs an
update it seems unlikely to get, so we're gonna monkey-patch it until
we can find a viable replacement.

isislovecruft/python-gnupg#250
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🪄🪄🪄🪄

Testing

  • CI should be green.
  • make test-focal should pass.
  • In the source interface, submit a message and a file.
  • Confirm that you can download those from the journalist interface and decrypt them.
  • Send a reply to the source, and confirm that it's readable in the source interface.

Thank you @rmol for this. Focal has green CI.

Here 23 means 23 :: The key is compliant with compliance mode "de-vs". and de-vs is a German standard to handle secret information https://de.wikipedia.org/wiki/Verschlusssache.

@kushaldas kushaldas merged commit 6b39892 into develop Nov 5, 2020
@kushaldas kushaldas deleted the add-pbp-kludge branch November 5, 2020 09:46
@eloquence eloquence added this to the 1.7.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_submit_message and test_submit_file failure on Focal container
3 participants