Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2 onion deprecation warning to securedrop-admin #5370

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add v2 onion deprecation warning to securedrop-admin #5370

merged 1 commit into from
Jul 14, 2020

Conversation

eloquence
Copy link
Member

Status

Ready for review

Description of Changes

Fixes #5361

Adds a simple deprecation warning for the v2 setting, regardless of the current value.

Test plan

  • Check out this branch in a real or virtualized Tails Admin Workstation
  • Run ./securedrop-admin sdconfig
  • Observe that the output is clean and understandable, and that the tool works as before

Checklist

  • make -C admin test passes locally

@kushaldas kushaldas force-pushed the 5361-cli-v2-deprecation branch from 242d699 to 0ab186c Compare July 14, 2020 10:43
kushaldas
kushaldas reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as before along with new message.

kushaldas
kushaldas approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Approved", I wanted to click the "Approve" button :(

@kushaldas kushaldas merged commit fabc609 into develop Jul 14, 2020
@rmol rmol added this to the 1.5.0 milestone Jul 14, 2020
@zenmonkeykstop zenmonkeykstop mentioned this pull request Jul 20, 2020
Closed
18 tasks
@legoktm legoktm deleted the 5361-cli-v2-deprecation branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@emkll emkll Awaiting requested review from emkll

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Add v2 deprecation warning to securedrop-admin
3 participants
@eloquence @kushaldas @rmol