Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyserver to keys.openpgp.org for comms key #4576

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

eloquence
Copy link
Member

Status

Ready for review

Description of Changes

Part of #4128

Testing

  • Use a virtualized Tails env or a prod-like setup to test this PR.
  • Remove the securedrop@freedom.press key from your keyring
  • Run the securedrop-admin logs playbook from this branch and verify that the key is successfully imported and the logs are encrypted to the comms key

Deployment

This is important mitigation against cert flooding attacks, so admins should be encouraged to update their workstations to pick up this fix

Checklist

  • I have followed my own test plan

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #4576 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4576   +/-   ##
========================================
  Coverage    82.53%   82.53%           
========================================
  Files           45       45           
  Lines         3121     3121           
  Branches       339      339           
========================================
  Hits          2576     2576           
  Misses         458      458           
  Partials        87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613342e...5f4025f. Read the comment docs.

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eloquence, works as expected in Tails: the key is imported and the logs are encrypted to the correct key.

@emkll emkll merged commit eb55fcd into develop Jul 2, 2019
@emkll emkll deleted the update-keyserver-for-logs-playbook branch July 2, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants