Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: output the hashes of all RPM packages without their signatures #62

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

cfm
Copy link
Member

@cfm cfm commented Feb 28, 2025

#61 proposes to have reviewers check that:

- [ ] Unsigned RPM after running `rpm --delsign` (use same version of rpmsign from the build container) on the signed RPM results in the checksum found in the build logs

I think this is worth automating just one step further, indeed a step towards automating it entirely as anticipated by freedomofpress/securedrop-builder#418, as we already do for .deb packages from their .buildinfo files.

This is a step towards automating the check of pre-signature
reproducibility proposed by freedomofpress/securedrop-builder#418.
@cfm cfm requested a review from rocodes February 28, 2025 00:11
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks.

@legoktm legoktm merged commit e36ef1f into main Mar 7, 2025
4 checks passed
@legoktm legoktm deleted the check-unsigned branch March 7, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants