Completes flake8 linting of Python files #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 2, 2018 19:18
For real this time! Added a `find` command to run `file` on every file and execute flake8 on any that `file` identifies as a Python script. Still running the `flake8 .` command separately. The disadvantage to this approach is that there are two flake8 runs, so errors in the first will cause the Makefile target to exit, without checking the other files. That's acceptable: we'll still catch errors in CI and locally, although it may take two runs of `make flake8` in order to catch them.
All changes were cosmetic, specifically whitespace-related.
Changes are cosmetic, specifically whitespace-related. Modified some command calls by creating a "cmd" variable to aid in readbility (and prevent overly long lines).
Includes changes to multiple scripts under `sd-journalist/`, for Flake8 compliance. Changes were cosmetic.
Substantial diff here, but changes are almost entirely cosmetic. Moved the sys.path.insert call to below the module imports, to resolve several E402s violations.
Only newer versions of Flake8 throw an E305 when two newlines are missing from *after* a function or class declaration. Should be in line with what we're using in CI (which is not pinned to a specific version of flake8 at present).
joshuathayer
reviewed
Feb 6, 2018
| @@ -111,7 +128,7 @@ if __name__ == '__main__': | |||
| d.show() | |||
|
|
|||
| if sigfile != "": | |||
| # tyvm https://stackoverflow.com/questions/6215690/how-to-execute-a-method-automatically-after-entering-qt-event-loop | |||
| # tyvm https://stackoverflow.com/questions/6215690/how-to-execute-a-method-automatically-after-entering-qt-event-loop # noqa: E501 | |||
There was a problem hiding this comment.
Yes, noqa on E501 permits the extra-long line. I'd much rather skip linting on a URL than break the URL up over multiple lines in order to satisfy the linter!
|
This looks great to me. I'll run tests once my #67 review is done and if they pass, |
joshuathayer
approved these changes
Feb 6, 2018
charles-boyd
pushed a commit
to charles-boyd/securedrop-workstation
that referenced
this pull request
Sep 5, 2018
…ke8-linting Completes flake8 linting of Python files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62, which falsely alleged it linted "all" Python files. It didn't: it only ran
flake8 ., and trustedflake8to discover all Python files. Here, we add afindcommand to discover Python files, which catches scripts and other helpers that do not end in*.py.Changes are quite cosmetic, but it's still worth running the test suites locally to ensure no breakage. In particular, don't forget to run the integration tests in the
sd-journalistVM, as described in the README.