Skip to content
This repository was archived by the owner on Jan 7, 2024. It is now read-only.

securedrop-sdk 0.2.0 #142

Merged
merged 1 commit into from
Oct 21, 2020
Merged

securedrop-sdk 0.2.0 #142

merged 1 commit into from
Oct 21, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Towards #141

@sssoleileraaa
Copy link
Contributor Author

Damn. I created the flakiness by adding randomness to submissions being marked as read in create_dev_data.py. I htink the right thing to do is to update that test so that it only selects one of those submssions that is unread, or creates an unread submission rather than relying on what's in the default db.

@sssoleileraaa
Copy link
Contributor Author

(see freedomofpress/securedrop#5580)

emkll
emkll approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emkll emkll merged commit a7a8fe2 into main Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emkll emkll emkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sssoleileraaa @emkll