Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop selecting a source on sync #981

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 23, 2020

Description

Replace SourceList.get_current_source with SourceList.get_selected_source. QListWidget.currentItem() returns something even if no item has been selected, which is not what we want when deciding whether to populate the conversation view after sync.

Fixes #962.

Test Plan

  • Start the client. Don't touch nothin'.
  • Wait through a sync.
  • No source should be selected after the sync; the empty conversation view with instructions should still be shown.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Replace SourceList.get_current_source with
SourceList.get_selected_source. QListWidget.currentItem() returns
something even if no item has been selected, which is not what we want
when deciding whether to populate the conversation view after sync.
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as excepted, approved 👍 🦄

@kushaldas kushaldas merged commit f1e935c into master Mar 24, 2020
@kushaldas kushaldas deleted the selected-not-current-source branch March 24, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source selected by default on startup
2 participants