-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source widget polish #522
Source widget polish #522
Conversation
If you want to test this with a sample preview string, you can use mine, which is already the correct lenght: self.preview = QLabel('Parsley shallot courgette tatsoi pea sprouts fava bean collard greens dandelion okra wakame tomato. Dandelion cucumber earthnut pea peanut soko zucchini.') |
For review, compare with zeplin style guide for source widget. Just compare with the min size one since the sourcelist width is fixed for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Plan update: To see mock preview text you can set
This is for the purpose of making sure it uses the correct font styles etc. for when we actually have the backend functionality to support getting the last activity of a conversation and update an individual source widget in the source list to display it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source widget displays as described and conforms to Zeplin version. The paperclip is displayed for conversations with downloads, and not otherwise, and the date displays as described.
Description
Towards #332
Move timestamp to "metadata" column below paperclip icon and polish source widget and format it to be 'DD MMM' (day and three-letter month). This also fixes a bug on
master
where the icon is partially hidden whenever there is a scrollbar in the sourcelist.When no attachment exists, the timestamp aligns with the preview header (source name), otherwise it aligns with the first line of the preview text.
Note: The paperclip provided in the inventory list needs modification either in Qt (will require some refactoring) or in the SVG file itself (can be done with a transformation function).