Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source widget polish #522

Merged
merged 5 commits into from
Aug 13, 2019
Merged

Source widget polish #522

merged 5 commits into from
Aug 13, 2019

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Aug 6, 2019

Description

Towards #332

Move timestamp to "metadata" column below paperclip icon and polish source widget and format it to be 'DD MMM' (day and three-letter month). This also fixes a bug on master where the icon is partially hidden whenever there is a scrollbar in the sourcelist.

When no attachment exists, the timestamp aligns with the preview header (source name), otherwise it aligns with the first line of the preview text.

source-widget-w-scrollbar

Note: The paperclip provided in the inventory list needs modification either in Qt (will require some refactoring) or in the SVG file itself (can be done with a transformation function).

@sssoleileraaa
Copy link
Contributor Author

If you want to test this with a sample preview string, you can use mine, which is already the correct lenght:

self.preview = QLabel('Parsley shallot courgette tatsoi pea sprouts fava bean collard greens dandelion okra wakame tomato. Dandelion cucumber earthnut pea peanut soko zucchini.')

@sssoleileraaa
Copy link
Contributor Author

For review, compare with zeplin style guide for source widget. Just compare with the min size one since the sourcelist width is fixed for now.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the dev SD core environment and running the client from the same dev VM, I'm not seeing any preview text (or the branding image, though not in scope for this PR). Screenshot attached.

Otherwise the source widget matches the description and Zeplin version.

missingpreview

@sssoleileraaa
Copy link
Contributor Author

Test Plan update:

To see mock preview text you can set self.preview in widgets.py:

self.preview = QLabel('Parsley shallot courgette tatsoi pea sprouts fava bean collard greens dandelion okra wakame tomato. Dandelion cucumber earthnut pea peanut soko zucchini.')

This is for the purpose of making sure it uses the correct font styles etc. for when we actually have the backend functionality to support getting the last activity of a conversation and update an individual source widget in the source list to display it.

@zenmonkeykstop zenmonkeykstop dismissed their stale review August 13, 2019 17:27

misunderstood scope

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source widget displays as described and conforms to Zeplin version. The paperclip is displayed for conversations with downloads, and not otherwise, and the date displays as described.

@sssoleileraaa sssoleileraaa merged commit 68c264a into master Aug 13, 2019
@sssoleileraaa sssoleileraaa deleted the source-widget-polish branch August 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants