Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some minor run-time option problems #15

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fixed some minor run-time option problems #15

merged 1 commit into from
Mar 26, 2019

Conversation

chick
Copy link
Contributor

@chick chick commented Mar 25, 2019

  • --rank-dr option -o changed to -j to avoid conflict with output
  • --rank-elements option -j changed to -r to avoid conflict with just-top-level
  • if no directory specified and input does not appear to have a directory, use "./"

@chick
Fixed some minor run-time option problems
0f56db3 
- --rank-dr option -o changed to -j to avoid conflict with output
- --rank-elements option -j changed to -r to avoid conflict with just-top-level
- if no directory specified and input does not appear to have a directory, use "./"
@chick chick added the bug Something isn't working label Mar 25, 2019
@chick chick self-assigned this Mar 25, 2019
@chick chick requested a review from ucbjrl March 25, 2019 19:54
ucbjrl
ucbjrl approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this warrants a new SNAPSHOT release. It shouldn't impact any of the existing SNAPSHOT releases (I think only bootcamp uses diagrammer).

src/main/scala/dotvisualizer/FirrtlDiagrammer.scala
@@ -7,6 +7,7 @@ import java.io.{File, PrintWriter}
import chisel3.experimental.ChiselAnnotation
import dotvisualizer.transforms.{MakeDiagramGroup, ModuleLevelDiagrammer}
import firrtl._
import firrtl.stage.TargetDirAnnotation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this now required? I don't see any new references to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TargetDirAnnotation lives in two places, one is deprecated. This overrides the import firrtl.annotations._ that brings in the deprecated one.

@chick chick merged commit ea4dd78 into master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucbjrl ucbjrl ucbjrl approved these changes

Assignees

@chick chick

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chick @ucbjrl