Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Move server/docs/README.md into CONTRIBUTING.md, per Quincy #397

Merged

Conversation

allella
Copy link
Contributor

@allella allella commented Aug 14, 2020

Closes nothing.

Per Quincy's suggestion to consolidate docs into the Wiki and Contributing.md
and #360 had to do the following:

  • Added volunteer roles to existing CONTRIBUTING.md table
  • moved server/docs/README.md to the end of CONTRIBUTING.md

@Zeko369 holler if this is going to cause a merge conflict or if any of the contents of server/docs/README.md are no longer relevant after the recent rework.

@allella allella added the Documentation Improvements or additions to documentation label Aug 14, 2020
| Name | GitHub | Twitter |
|:----------------|:-------|:--------|
| Quincy Larson | [`@QuincyLarson`](https://github.com/QuincyLarson) | [`@ossia`](https://twitter.com/ossia)|
| Name | GitHub | Role |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allella I would extract this into README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this into CONTRIBUTING.md and we'll consider moving to README

@Zeko369
Copy link
Member

Zeko369 commented Aug 15, 2020

@allella I'm pretty sure I don't have access to your repo (opening a PR there seems like to much work), so I added some inline suggestions for ServerSideDocs updates

allella and others added 10 commits August 15, 2020 12:30
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
Co-authored-by: Fran Zekan <zekan.fran369@gmail.com>
@allella allella merged commit 86b836e into freeCodeCamp:master Aug 15, 2020
@allella allella deleted the docs/move-server-notes-to-contributing branch August 15, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants