remove unnecessary docker images for local sources

[ianchen0119]

No description provided.

[abousselmi]

The new dockerfiles were added by PR #69 that was approved by @tim-ywliu
If you want to remove it, it would be better if you entirely revert the PR.
@tim-ywliu what do you think about this ?

[tim-ywliu]

The new dockerfiles were added by PR #69 that was approved by @tim-ywliu If you want to remove it, it would be better if you entirely revert the PR. @tim-ywliu what do you think about this ?

@abousselmi I think it is better to reuse same Dockerfile to build and less maintaining effort.

[tim-ywliu]

move go-gtp5gnl tool build to base Dockerfile and copy it from base

[ianchen0119]

If I move this build action to the base Dockerfile, I think it can't be optional due to we won't use the base image directly (Won't use DEBUG_TOOLS).

[tim-ywliu]

can merge all base Dockerfile into one.
use COPY free5gc as default Dockerfile setting.
always git clone free5gc into base folder first when using local build.

[abousselmi]

LGTM

[aviweit]

Hi @ianchen0119 , @tim-ywliu ,
I installed lasted free5gc-compose repository that includes this PR. I would like to ask how can I build a specific network function (e.g. amf) as supported by PR #69?

The readme states:

# Alternatively you can build specific NF image e.g.:
make amf
docker compose -f docker-compose-build.yaml build free5gc-amf

I tried this but make amf fails with no rule. Please note that Makefile of PR #69 included rules for specific NFs.

Thanks.

[ianchen0119]

Hi @aviweit
You can try this:

make all
docker compose -f docker-compose-build.yaml build free5gc-amf

[aviweit]

Hi @ianchen0119 ,

I tried it.
make all compiles all NFs into the base docker image, even if I only modify a specific NF code (e.g. smf).
Compiling all NFs takes long time.

I looked into docker compose -f docker-compose-build.yaml build free5gc-amf.
It uses nf_amf/Dockerfile that copies amf binary and libraries from base image. That binary, from base image, had been created during compilation time of all NFs, via make all command.

I think it would be very good to provide the ability to compile a specific NF which saves a lot of time. I am using #69 to compile only the NF I am working on.
The Makefile has rule for every NF. That rule delegates the request to the free5gc/Makefile and generates docker image only for that NF binaries.

What do you think ?

[ianchen0119]

Hi @aviweit
I think the PR you proposed can save more time on your demand certainly.
But I have the problem is:
Each NF has its own Dockerfile.nf file and all of these files have a lot of similarities.
Do you have any idea to remove the duplicated file?