Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AbstractDict config #185

Closed
tlienart opened this issue Jan 31, 2022 · 1 comment · Fixed by #186
Closed

Allow AbstractDict config #185

tlienart opened this issue Jan 31, 2022 · 1 comment · Fixed by #186

Comments

@tlienart
Copy link
Contributor

Is there a reason why config is type restricted to Dict and not to AbstractDict? e.g. here:

Literate.jl/src/Literate.jl

Line 126 in ebe1cfd

config::Dict,

Not a big deal but relaxing it would allow to use LittleDict for instance.
@tlienart tlienart changed the title Allow abstractdict Allow AbstractDict config Jan 31, 2022
@fredrikekre
Copy link
Owner

No reason.

@tlienart tlienart mentioned this issue Jan 31, 2022
Merged
fredrikekre pushed a commit that referenced this issue Feb 1, 2022
@tlienart
Relax Dict -> AbstractDict for user configurations, closes #185. (#186)
0794936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relaxing Dict->AbstractDict tlienart/Literate.jl
2 participants
@tlienart @fredrikekre