Add openconsole support #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While structopt also uses clap under the hood, the configuration through annotations allows for significantly more maintainable and concise CLI definition. This will also make it far easier to have platform-specific options, which is problematic with clap since no individual methods can be removed from its builder. The change in Alacritty's CLI has been kept to a minimum with the only significant changes being the `--version` flag listed before the `-v` flag and the authors all on the same line.
During the deprecation of the 'background_opacity' field, it was incorrectly renamed to 'window_opacity'. This changes that back to ensure the old field still works and a warning is emitted accordingly. See the original regression here: alacritty@c24d7df#diff-f92f0b1ad70a7b75b7266f3c9e569025e023d186814aa88c2b690800850ccb78L72-R73 Fixes alacritty#5437.
The "consoleapi" feature in the winapi crate is required when using things from the `winapi::um::consoleapi` module.
To make it possible to detect the replacement of the configuration file when it is a symlink, the symlinks path has to be observed in addition to the canonicalized path. That way changes to either file will trigger a live config reload. Multiple layers of symlinks would still not get detected when any symlink other than the configuration file itself is replaced, but this patch should cover most realistic usage scenarios.
While the custom merge strategy can make things simpler in some scenarios, it has repeatedly shown to silently introduce errors that have to be manually spotted and corrected after the fact. It's much more reliable and efficient to always manually oversee potential conflicts, rather than letting them slip through half of the time and having to contribute follow-up patches.
While it might be nice to have the full `Passwd` struct around should anything ever change in the future, there's really no reason why Alacritty would need this information. So just removing things for now makes more sense than adding `#[allow(unused)]`.
`ErrorKind::Other` no longer includes `EIO` since Rust 1.55:
https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#stdioerrorkind-variants-updated
It was not precise enough from the very beginning, as the comment says
that only EIO should be hidden, while the code was any uncategorised
errors.
In this change I went through all current rustfmt configuration options and expanded our existing configuration with overrides whenever deemed appropriate. The `normalize_doc_attributes` option is still unstable, but seems to work without any issues. Even when passing macros like `include_str!` that is recognized properly and not normalized. So while this wasn't an issue anywhere in the code, it should make sure it never will be. When it comes to imports there are two new major additions. The `imports_granularity` and `group_imports` options. Both mostly just incorporate unwritten rules that have existed in Alacritty for a long time. Unfortunately since `alacritty_terminal` imports in `alacritty` are supposed to be separate blocks, the `group_imports` option cannot be used.
The existing cursor inversion logic was causing more problems than it solved, without solving the problem of invisible cursor when inverting a cell with matching foreground and background colors. This patch reworks this logic and only inverts the cursor when the foreground and background colors of the cursor are similar and the cursor colors aren't set to fixed RGB values. Fixes alacritty#4564. Fixes alacritty#5550.
Previously Alacritty would always initialize only a single terminal emulator window feeding into the winit event loop, however some platforms like macOS expect all windows to be spawned by the same process and this "daemon-mode" can also come with the advantage of increased memory efficiency. The event loop has been restructured to handle all window-specific events only by the event processing context with the associated window id. This makes it possible to add new terminal windows at any time using the WindowContext::new function call. Some preliminary tests have shown that for empty terminals, this reduces the cost of additional terminal emulators from ~100M to ~6M. However at this point the robustness of the daemon against issues with individual terminals has not been refined, making the reliability of this system questionable. New windows can be created either by using the new `CreateNewWindow` action, or with the `alacritty msg create-window` subcommand. The subcommand sends a message to an IPC socket which Alacritty listens on, its location can be found in the `ALACRITTY_SOCKET` environment variable. Fixes alacritty#607.
The original multiwindow PR added a new manpage, however this was not properly documented or included in our CI. This patch resolves these issues.
Fixes alacritty#5492. Co-authored-by: Christian Duerr <contact@christianduerr.com>
The current completions required a lot of domain-specific knowledge about each individual shell and their completion functionality. Much of which is sparsely documented. While clap does not generate perfect completions, since parameters like `-e` are missing completions, it does a reasonable job while requiring no work on writing these completions. Since access to `cli.rs` isn't possible from the `build.rs`, these completions aren't always generated on build. Instead a test verifies that there has been no changes to these completions and provides a simple code sample for re-generating them. This should provide a simple solution with minimal overhead.
Alacritty's `msg create-window` subcommand would previously inherit all the CLI parameters from the original executable. However not only could this lead to unexpected behavior, it also prevents multi-window users from making use of parameters like `-e`, `--working-directory`, or `--hold`. This is solved by adding a JSON-based message format to the IPC socket messages which instructs the Alacritty server on which CLI parameters should be used to create the new window. Fixes alacritty#5562. Fixes alacritty#5561. Fixes alacritty#5560.
Fixes alacritty#5603. Fixes alacritty#5422. Fixes alacritty#5350. Fixes alacritty#4105. Co-authored-by: Christian Duerr <contact@christianduerr.com>
This fixes an issue where the vi cursor would move down one line if it's positioned at the topmost visible line, while at least partially scrolled up into history, when new lines are added to the terminal. This problem is caused by using a display offset of a grid not scrolled yet when scrolling and determining a new vi cursor position.
This update includes crossfont 0.3.2, which updates the macOS font fallback behavior. Fixes alacritty#3271.
This patch resolves a behavior that display area doesn't keep track of content in a scrollback buffer due to display offset reset when viewport clear is invoked. This is similar to alacritty#5341, but this problem is caused by viewport clear instead of new outputs to the viewport.
To allow applications spawned by Alacritty to make use of the shell/foreground process' working directory, it is now set for all new processes spawned by Alacritty on Unix platforms. Fixes alacritty#5616. Co-authored-by: Christian Duerr <contact@christianduerr.com>
The existing PID/FD atomics in alacritty_terminal/src/tty/unix.rs were shared across all Alacritty windows, causing problem with the new multiwindow feature. Instead of sharing these between the different windows, the master FD and shell PID are now stored on the `window_context`. Unfortunately this makes spawning new daemons a little more complicated, having to pass through additional parameters. To ease this a little bit the helper method `spawn_daemon` has been defined on the `ActionContext`, making it accessible from most parts of Alacritty's event loop. Fixes alacritty#5700.
This adds capabilities for focus in/out (XF, kxIN, kxOUT) and bracketed paste (BD, BE, PE, PS).
Previously the character suppression was only reset whenever a key was released. However this did not take key repetition into account. Now every key down also resets the character suppression. This should work since the `ReceivedCharacter` is always received immediately after the `KeyboardInput` without the chance of a racing condition where another keyboard event interrupts the two.
Route string terminal input through 'ActionContext::paste' instead of char by char write improving performance by utilizing bracketed paste mode when it's reasonable.
This patch enables binding chains that go beyond mode changes by allowing bindings to be defined for modes they do not usually have an effect in.
This should help with troubleshooting the dependency crates like winit.
The 0.28.4 was yanked.
This is not a real fix for the issue given that dbus method sctk-adwaita is using will being called anyway. The proper fix will be available with the winit's 0.29.0 release. Right now the delay reduced from around 20 seconds to 100ms on a systems with broken xdg-desktop-portal setup.
Fix Node 12 deprecation warnings in action runs.
The recent version on xdg crate moved to home crate which is used by cargo. Thus to query for home directory we can use the home dependency instead which is smaller.
Fixes alacritty#6879. Fixes alacritty#6874.
Make the renderer more debuggable by adding extra logging and using `GL_KHR_debug` when running with the debug log level.
Co-authored-by: Christian Duerr <contact@christianduerr.com>
This fixes a regression introduced in cb7ad5b which swapped the green and blue values when constructing the 216-color RGB cube. Fixes alacritty#6951.
The intention was to show it, however it was hidden due to wrong comparisson check.
This rewrites the existing manpages to use the `scdoc` format, making it simpler to read and edit the manpages without intricate roff knowledge. Some minor changes to the manpages were made in the process, mostly focusing on correcting some of the wording. The list of maintainers has also changed to ensure people not involved in the project anymore aren't unnecessarily contacted for support.
Signed-off-by: Dennis Maier <d.maier94@web.de> Co-authored-by: Christian Duerr <contact@christianduerr.com>
Windows is known to send zero sizes from winit in Risezed and now in ScaleFactorChanged events. They were handled in Resized, but not in ScaleFactorChanged. Fixes alacritty#6949.
Co-authored-by: Christian Duerr <contact@christianduerr.com>
This explicitly specifies resolver "2" in the root manifest, to fix a warning introduced in a recent nightly release.
This switches Alacritty's default configuration format from yaml to toml. While yaml is still supported, it is done by converting it to toml and should be removed entirely in the future. All existing features were persisted based on my testing. Behavior should not change much, though `--option` might have slightly different behavior since the entire line is not interpreted as one line of toml. A new `alacritty migrate` subcommand has been added which allows automatic migration from yaml to toml. This also could be used as a facility to automatically fix configuration file changes in the future. Closes alacritty#6592.
If the conpty.dll and OpenConsole.exe files from the Windows Terminal project are placed in the same directory as the alacritty executable they will be used instead of implementation provided by Windows. This way you don't need to wait for new Windows releases to get bug fixes and new features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to document all user-facing changes in the
CHANGELOG.mdfile.If support for a new escape sequence was added, it should be documented
in
./docs/escape_support.md.Since
alacritty_terminal's version always tracks the next release, make surethat the version is bumped according to semver when necessary.
Draft PRs are always welcome, though unless otherwise requested PRs will
not be reviewed until all required and optional CI steps are successful
and they have left the draft stage.