More updates and fixes #3
Conversation
updated version number
A lot has happened with node compatibility and what works and not. Pulled deps from sage 8.5.0 and updated package.json
new devdeps in package.json requires some changes in the gulpfile. Removed ”browser” from browser sync and opens the default browser instead.
was added to Sage in 8.4.1. Added here as well.
pulled the changelog from sage 8.5.0 and added the changes as well.
added vendor to gitignore like later sage version using composer.json.
will be removed later on. Added to verify functionality for now
commented out row colours
instead of using everything always we add each file to allow easier removal of unused components
rewritten with attribute escapes, sanitation and alternate php style. Added namespace
added namespace, fixed tabbing and intents.
fixed strings to translatable, fixed spaces according to WordPress-Core code style. Most of it anyway.
|
Thanks for your work on this! When including the individual js files as you have, shouldn't Babel be used to transpile during the Gulp task? https://foundation.zurb.com/sites/docs/javascript.html#babel-required |
|
You might be right. I only tested in modern browsers and meant to revisit it sooner than I have. If you have the time, please try and report back. Otherwise I'll keep it in mind when I get around to update it to foundation 6.3 that was released a few days ago. |
|
Cool. If I get a few to work on it I'll post back here. Please do the same. Also it looks like foundation.core.js and foundation.util.mediaQuery.js should be loaded first. https://foundation.zurb.com/sites/docs/javascript.html#file-structure |
|
I'll make sure to mirror the JS inclusion order used in 6.3 when I get to it. Thanks for noticing it! |
|
@christianmagill it just hit me: do we need babel translation if we include plugins from /dist folder? I'm not sure what's required since we do not really build from source. I'll have to do some digging. |
|
I'm not sure. Would be nice to have es6 available though. |
|
So I took a look, and files within foundation-sites/dist/js does not require babel. If we however use files from foundation-sites/js we would absolutely need it. But I agree that we should have babel there anyway, so it's easy to use ES6 whenever. |
|
Good to know. |
|
Since Beta 2 of Sage 9 adds the option to select Foundation as framework I will be abandoning this. I can't justify investing the time since an official solution has arrived (altough in beta). |
|
Sounds good. I was excited to see the option appear. Now I'm just hoping blade becomes an option as well. |
|
Blade is actually there since beta 1. Some issues with woocommerce but they're working on it. https://github.com/roots/sage/releases/tag/9.0.0-beta.1 I'm reluctant to use beta versions for serious projects but really looking forward to the first real release. Whenever that happens. |
This includes all updates up to Sage 8.5.0 about a month ago, all the fixes from @chuckn246 (plus refactored some of his code with proper attribute escapes, different PHP style, better alignment with WordPress-Core code style plus made more strings translatable, adds namespaces).
So it works with newer versions of node, incorporates composer and more.
Many thanks to @chuckn246 for the hard word on the features. Sorry I didn't pulled your changes correctly into my fork instead of this..
Commented out flex-grid since Zurb recommends using only one at a time.