Improve contribution workflow #370
Conversation
pratikb64
commented
Mar 4, 2025
•
pratikb64
commented
- Add notification banner to show pending reviews of the page and space [feature] Notification for pending drafts #346
- Edit and approve change from a list view / table [feature] Edit and approve changes #348
- [ ]
Wiki
|
||||||||||||||||||||||||||||||
| Project |
Wiki
|
| Branch Review |
user-contri-improvements
|
| Run status |
|
| Run duration | 01m 24s |
| Commit |
|
| Committer | Pratik Badhe |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
5
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
0
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
|
Can you add screenshots in your PR? |
|
This is how the notification banner and badges in app/space switcher will look like |
|
Some dieas. Since I have to land on a page to discover if there are any contributions, just show on every page of an Wiki Space. For example "There are 50 pending reviews on ERPNext" When I click on the banner, it can show me a modal of the pages where there are contributions. If I am on a page with pending reviews, then show "There are 3 pending reviews on this page". If none, show global pending or just no notification. The contributions can show up on a separate tab on a page (only visible to administrators). On the tab, when you click on an item, you can show the changes in a modal with an "Approve" or "Reject" button. Also check espresso for banner UI |
…contri-improvements
|
This is how that table is looking (ignore the black box). Pagination, approve and reject are working
|
