fix: set margin fields for purchase documents when updating items #43475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarvora
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
sagarvora
force-pushed
the
set-margin-values
branch
from
59880b0
to
7be4d56
Compare
sagarvora
added
backport version-14-hotfix
This was referenced Oct 2, 2024
sagarvora
added a commit
that referenced
this pull request
Oct 2, 2024
…-43475 fix: set margin fields for purchase documents when updating items (backport #43475)
sagarvora
added a commit
that referenced
this pull request
Oct 2, 2024
…-43475 fix: set margin fields for purchase documents when updating items (backport #43475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rate changes on "update items" because both discount and margin are set.
Solution
revert: 81c2175
margin fields introduced in: #24685