fix: allow tax rule filter on tax category name with % #43328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat102
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ruthra-kumar
approved these changes
Sep 23, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Sep 23, 2024
…-43328 fix: allow tax rule filter on tax category name with % (backport #43328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When the tax category name has %, frappe.db.escape make it as %%. so the tax category name is not getting matched and sales taxes and charges template is not fetched from the tax rule
internal ref: 22418
Before:
Tax Rule-Issue
After:
Tax Rule-Fix
Backport needed: v15