Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set group_by condition to "Group by Voucher (Consolidated)" if None and voucher_no is set #43235

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: set group_by condition to "Group by Voucher (Consolidated)" if None and voucher_no is set #43235

merged 1 commit into from
Sep 24, 2024
+3 −0

Conversation

vishakhdesai
Copy link
Contributor

Issue:

image

  • Fix: To avoid thse double rows for opening and closing entries, setting the group_by filter as Group by Voucher (Consolidated) if group_by is not set and voucher_no is set,

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 16, 2024
@ruthra-kumar ruthra-kumar self-assigned this Sep 17, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 September 17, 2024 04:57
@ruthra-kumar ruthra-kumar merged commit 6954bfc into frappe:develop Sep 24, 2024
14 checks passed
@mergify mergify bot mentioned this pull request Sep 24, 2024
Merged
ruthra-kumar added a commit that referenced this pull request Sep 24, 2024
@ruthra-kumar
Merge pull request #43360 from frappe/mergify/bp/version-15-hotfix/pr…
49d5b7c 
…-43235

fix: set group_by condition to "Group by Voucher (Consolidated)" if `None` and voucher_no is set (backport #43235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishakhdesai @ruthra-kumar