Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary condition on 'voucher_no' (backport #42936) #42948

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 27, 2024

if args.get("party_type") != "Employee" and not args.get("voucher_no"):


This is an automatic backport of pull request #42936 done by Mergify.

(cherry picked from commit fb32d2c)
@mergify mergify bot requested a review from deepeshgarg007 as a code owner August 27, 2024 11:05
@mergify mergify bot requested a review from ruthra-kumar as a code owner August 27, 2024 11:05
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 27, 2024
@ruthra-kumar ruthra-kumar merged commit 813b699 into version-14-hotfix Aug 27, 2024
10 of 11 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-14-hotfix/pr-42936 branch August 27, 2024 11:39
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants