Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: brand js and allow quick entry #42829

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

Nihantra-Patel
Copy link
Contributor

Version: Dev & 15

fixes: #42780 & https://discuss.frappe.io/t/after-frappe-update-unable-to-create-new-brand/131226?u=ncp

Before:

before_brand.mov

After:

after_brand.mov

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 20, 2024
@Nihantra-Patel Nihantra-Patel removed the needs-tests This PR needs automated unit-tests. label Aug 20, 2024
@Nihantra-Patel Nihantra-Patel merged commit a1183f0 into frappe:develop Aug 20, 2024
18 checks passed
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
* refactor: brand js and allow quick entry

* refactor: brand js and allow quick entry --prettier

* refactor: brand js and allow quick entry --prettier

(cherry picked from commit a1183f0)

# Conflicts:
#	erpnext/setup/doctype/brand/brand.json
Nihantra-Patel added a commit that referenced this pull request Aug 20, 2024
* refactor: brand js and allow quick entry (#42829)

* refactor: brand js and allow quick entry

* refactor: brand js and allow quick entry --prettier

* refactor: brand js and allow quick entry --prettier

(cherry picked from commit a1183f0)

# Conflicts:
#	erpnext/setup/doctype/brand/brand.json

* refactor: brand js and allow quick entry --refactor

---------

Co-authored-by: Nihantra C. Patel <141945075+Nihantra-Patel@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add Brand Button not work
1 participant