fix: add the company in payment request bcz delete company transactions #42664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihantra-Patel
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
I think the company field is implicitly set. On a multi-company setup, this might incorrectly set the same company for all PR's. Can you test this? |
|
Hi @ruthra-kumar, Video is long but check it out. multi-company.with.PR.mp4 |
This is exactly what I had suspected. Process flow should not rely upon user setting the correct session defaults. Not every user will do that. pr_company_after.mp4Explicit is always better than Implicit. |
|
With e300884, above issue should be fixed. |
ruthra-kumar
approved these changes
Aug 29, 2024
Nihantra-Patel
added a commit
that referenced
this pull request
Aug 29, 2024
…ns (backport #42664) (#42982) * fix: add the company in payment request bcz delete company transactions (cherry picked from commit 12834cc) # Conflicts: # erpnext/accounts/doctype/payment_request/payment_request.json * fix: link company when make payment request (cherry picked from commit e300884) * fix: add the company in payment request bcz delete company transactions --conflicts --------- Co-authored-by: Nihantra Patel <nihantra@frappe.io> Co-authored-by: Nihantra C. Patel <141945075+Nihantra-Patel@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
## [15.34.1](v15.34.0...v15.34.1) (2024-09-05) ### Bug Fixes * add the company in payment request bcz delete company transactions (backport [#42664](#42664)) ([#42982](#42982)) ([42e7725](42e7725)) * added app permission check for apps page ([a35ce12](a35ce12)) * adjust price insertion logic for internal suppliers/customers ([#42988](#42988)) ([daa75ee](daa75ee)) * auto reorder material request mail issue (backport [#43066](#43066)) ([#43068](#43068)) ([d2b2002](d2b2002)) * **capitalization:** debit cwip account instead of fixed asset account ([#42857](#42857)) ([f3c60ea](f3c60ea)) * company accounts setup_queries ([b99cdb5](b99cdb5)) * disabled batches showing in the list (backport [#43024](#43024)) ([#43069](#43069)) ([56dad7d](56dad7d)) * don't allow capitalizing only service item for new composite asset ([a833010](a833010)) * improve asset item matching logic ([3bb1867](3bb1867)) * indentation ([4d7c0c0](4d7c0c0)) * link Purchase Invoice and Receipt Items to Asset ([1121c66](1121c66)) * retain date filter when redirecting in Profit and Loss report ([f0e3fb4](f0e3fb4)) * typeerror on Payment Entry ([6d51d14](6d51d14)) * typerror on default_currency ([7d6984c](7d6984c)) * update develop_version in hooks ([6c8e0fd](6c8e0fd)) * validate component quantity according to BOM (backport [#43011](#43011)) ([#43014](#43014)) ([fee2255](fee2255))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 15
fixes: #42659
Before:
before_payment_request.mp4
After:
after_payment_request.mp4