Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: checkbox to control Payment Request creation (backport #42476) #42533

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 30, 2024

Payment Request created from Sales Order / Purchase Order is by default in Draft status. This makes it impossible to select a different naming series.

A New checkbox in Accounts Settings is added to control this behavior.
Screenshot 2024-07-26 at 6 56 07 AM

after.mp4

This is an automatic backport of pull request #42476 done by [Mergify](https://mergify.com).

(cherry picked from commit ce81fd9)

# Conflicts:
#	erpnext/accounts/doctype/payment_request/payment_request.py
Copy link
Contributor Author

mergify bot commented Jul 30, 2024

Cherry-pick of ce81fd9 has failed:

On branch mergify/bp/version-15-hotfix/pr-42476
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit ce81fd9ba6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/doctype/accounts_settings/accounts_settings.json
	modified:   erpnext/accounts/doctype/accounts_settings/accounts_settings.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/payment_request/payment_request.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 30, 2024
@ruthra-kumar ruthra-kumar merged commit 75271ca into version-15-hotfix Jul 30, 2024
11 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-42476 branch July 30, 2024 08:34
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.31.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants