fix: consider payment entries for checking if tds is deducted (backport #42305) #42484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 40b59de)
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
|
🎉 This issue has been resolved in version 15.31.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If TDS is adjusted from advance payment it was not considered in the TDS amount calculation.
Adv Payment = 500
TDS= 50
1 st Invoice = 500
TDS = 0 (Adjust from advance Payment)
2nd Invoice = 1000
Tax withheld amount = 1000+500
TDS = 150
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/18632
This is an automatic backport of pull request #42305 done by [Mergify](https://mergify.com).