Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SO, DN): only show permitted actions (backport #41384) #41441

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2024

Assume we have a user whose only permission is to read Sales Orders. We shouldn't display all the "Update Items" and "Create ..." buttons, because clicking them will just result in an error message and a frustrating user experience.

Before

All actions are available, regardless of permissions.

Bildschirmfoto 2024-05-08 um 16 21 10

After

Only permitted actions are displayed (none, in this case).

Bildschirmfoto 2024-05-08 um 16 20 45

The same applies to Delivery Note.


This is an automatic backport of pull request #41384 done by Mergify.

@ruthra-kumar
Copy link
Member

@barredterra
Is there any blocker for this backport?

@barredterra
Copy link
Collaborator

@ruthra-kumar I don't think so, only the backport of your fix that should be merged at the same time.

This comment was marked as outdated.

@stale stale bot added the inactive label Jun 16, 2024
@barredterra barredterra removed their assignment Jun 17, 2024
@barredterra
Copy link
Collaborator

@Mergifyio update

Copy link
Contributor Author

mergify bot commented Jun 17, 2024

update

✅ Branch has been successfully updated

@barredterra barredterra merged commit 7b322e7 into version-15-hotfix Jun 20, 2024
5 checks passed
@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-41384 branch June 20, 2024 13:58
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants