-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SO, DN): only show permitted actions (backport #41384) #41441
Merged
barredterra
merged 6 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-41384
Jun 20, 2024
Merged
fix(SO, DN): only show permitted actions (backport #41384) #41441
barredterra
merged 6 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-41384
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
May 13, 2024 13:43
@barredterra |
@ruthra-kumar I don't think so, only the backport of your fix that should be merged at the same time. |
This comment was marked as outdated.
This comment was marked as outdated.
@Mergifyio update |
✅ Branch has been successfully updated |
…y/bp/version-15-hotfix/pr-41384
(cherry picked from commit 47bc569)
🎉 This issue has been resolved in version 15.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume we have a user whose only permission is to read Sales Orders. We shouldn't display all the "Update Items" and "Create ..." buttons, because clicking them will just result in an error message and a frustrating user experience.
Before
All actions are available, regardless of permissions.
After
Only permitted actions are displayed (none, in this case).
The same applies to Delivery Note.
This is an automatic backport of pull request #41384 done by Mergify.