Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: usage of in_list (backport #40542) #40544

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2024

Usage of in_list is discouraged by our semgrep rules. Editing theses files would lead to a warning. This PR refactors the affected files in order to avoid future semgrep failures on unrelated PRs

Bulk-replace in_list(array, member) with array.includes(member):

(cherry picked from commit d238751)
@barredterra barredterra merged commit 745e653 into version-15-hotfix Mar 19, 2024
5 of 6 checks passed
@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-40542 branch March 19, 2024 11:49
@barredterra barredterra removed their assignment Mar 19, 2024
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants