Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validate SO and SI references in Delivery Notes (backport #40485) #40490

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 16, 2024

Validation to prevent incomplete references of Sales Orders and Sales Invoices in Delivery Note. Either both, against_sales_order and so_detail should be set or both should be unset. Same applies for against_sales_invoice and si_detail.

Ex:
Screenshot 2024-03-16 at 10 21 40 AM


This is an automatic backport of pull request #40485 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from rohitwaghchaure as a code owner March 16, 2024 09:29
@ruthra-kumar ruthra-kumar merged commit db5cd4e into version-15-hotfix Mar 16, 2024
12 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-40485 branch March 16, 2024 09:57
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants