fix: incorrect gross profit on the quotation (backport #40438) #40441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit f4a945a)
mergify
bot
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
## [14.65.2](v14.65.1...v14.65.2) (2024-03-14) ### Bug Fixes * added index for price_list column in Item Price ([d279e23](d279e23)) * Book depreciation until the asset disposal date and removed unwanted commits ([5fcf8c5](5fcf8c5)) * convert str to date ([34c3e75](34c3e75)) * flaky Accounts Receivable test case ([41bda58](41bda58)) * incorrect gross profit on the quotation (backport [#40438](#40438)) ([#40441](#40441)) ([fe54590](fe54590)) * linter issues ([ac0dd50](ac0dd50)) * linter issues ([668a931](668a931)) * linter issues ([acc0b2f](acc0b2f)) * minor fixes ([5cd9bf3](5cd9bf3)) * Patch to remove cancelled asset capitalization from asset ([23e256a](23e256a)) * Reload document on cancel to avoid document modified error ([c7ed854](c7ed854)) * **test:** manually filter rows and assert ([5fe200b](5fe200b)) ### Performance Improvements * Cache accounting dimension filter map ([e4bd173](e4bd173)) * Cached accounting dimensions details ([8cd8b8f](8cd8b8f)) * Caching in checking allowance for qty and amount ([8d682fa](8d682fa)) * Caching in gl entry ([b07769d](b07769d)) * Get bin details only for stock items ([6ff9e6e](6ff9e6e)) * Optimization for providional gl entries ([d7b738f](d7b738f)) * Optimzed code for merging similar gl entries ([aa75a60](aa75a60)) * Performance optimization for validating budget ([f204d81](f204d81)) * refactored handling provisional gl entries for non-stock items ([49c7436](49c7436)) * skip unnecessary validation while transaction cancellation ([05385e4](05385e4)) * validate expense against budget only if budget exists ([c15b2d5](c15b2d5))
|
🎉 This PR is included in version 14.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After Fix
This is an automatic backport of pull request #40438 done by [Mergify](https://mergify.com).