perf: Performance optmization for Purchase Invoice submission #40263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
nabinhait
force-pushed
the
pi-optimization
branch
from
ede6ead
to
aa75a60
Compare
|
🎉 This PR is included in version 14.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
nabinhait
added a commit
to nabinhait/erpnext
that referenced
this pull request
Mar 14, 2024
perf: Performance optmization for Purchase Invoice submission
nabinhait
added a commit
to nabinhait/erpnext
that referenced
this pull request
Mar 14, 2024
perf: Performance optmization for Purchase Invoice submission
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance optimization for Purchase Invoice submission and cancellation
This PR mainly tries to optimize the Purchase Invoice where there are a large number of service items in the invoice and provisional accounting is enabled.
Reported Usecase:
Number of service items in Purchase Invoice: 2750
Submit Time: ~10 mins
Cancel Time: > 20 mins (cancelled the job)
After Optimization:
Submit Time: ~2 mins
Cancel Time: ~30 secs