Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Item Tax template is not working for e-commerce #39547

Conversation

rohitwaghchaure
Copy link
Collaborator

In the item master set the item tax template and enabled the "Automatically Add Taxes and Charges from Item Tax Template" in the accounts settings, still then tax template has not applied in the e-commerce quotation

Screenshot 2024-01-25 at 11 09 16 AM

After Fix

Screenshot 2024-01-24 at 11 42 07 PM

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4f1e729) 60.14% compared to head (7d3240a) 60.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #39547   +/-   ##
========================================
  Coverage    60.14%   60.15%           
========================================
  Files          757      757           
  Lines        70696    70713   +17     
========================================
+ Hits         42523    42540   +17     
  Misses       28173    28173           
Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.48% <76.47%> (-0.10%) ⬇️

... and 3 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit c0a1188 into frappe:develop Jan 25, 2024
15 checks passed
rohitwaghchaure added a commit that referenced this pull request Jan 25, 2024
…-39547

fix: Item Tax template is not working for e-commerce (backport #39547)
rohitwaghchaure added a commit that referenced this pull request Jan 25, 2024
fix: Item Tax template is not working for e-commerce (backport #39547) (backport #39549)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant