fix(Material Request): consider project for item details #37215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
rohitwaghchaure and
s-aga-r
as code owners
barredterra
changed the title
s-aga-r
approved these changes
Sep 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
fix(Material Request): project in item details (cherry picked from commit 7c4ebe2)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
# [14.41.0](v14.40.0...v14.41.0) (2023-09-27) ### Bug Fixes * allow to select parent warehouse in the website item (backport [#37047](#37047)) ([#37173](#37173)) ([56657b6](56657b6)) * AP & AR summary filters to match AR (backport [#37248](#37248)) ([#37261](#37261)) ([1dc58b3](1dc58b3)) * apply gl report filters ([b4bc44d](b4bc44d)) * german translation of Sales and Purchase Invoice ([#37122](#37122)) ([8236814](8236814)) * incorrect `Parent Task` getting set for 2nd to nth child Task (backport [#37230](#37230)) ([#37240](#37240)) ([279f21d](279f21d)) * labels for `Stock Ledger Invariant Check` report (backport [#37150](#37150)) ([#37176](#37176)) ([f2bcfb5](f2bcfb5)) * **Material Request:** consider project for item details (backport [#37215](#37215)) ([#37221](#37221)) ([25f800d](25f800d)) * reserved qty for production plan ([#37251](#37251)) ([0a0d5b3](0a0d5b3)) * serial number decimal issue ([#37242](#37242)) ([78ab201](78ab201)) * set customer currency in pos_invoice if exists ([e0da8d2](e0da8d2)) * Update `advance_paid` in SO/PO after unlinking from advance entry ([1181dcf](1181dcf)) * validate duplicate serial no on submit in DN ([#37243](#37243)) ([70e2093](70e2093)) ### Features * `Stock Ledger Variance` report (backport [#37165](#37165)) ([#37183](#37183)) ([02fc67c](02fc67c)) * Toggle net values in Trial Balance report ([57c82c1](57c82c1))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Material Request didn't consider the Project while fetching item details. For example, when creating a Material Request from a Project, you'd expect the project's Default Cost Center to be used. However, the Material Request didn't consider the selected Project, which resulted in the company's Default Cost Center being set.
Solution
Pass the selected Project to
get_item_details.