-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deduplicate gain/loss JE creation for journals as payment #36911
Merged
ruthra-kumar
merged 5 commits into
frappe:develop
from
ruthra-kumar:deduplicate_gain_loss_journal_creation
Sep 3, 2023
Merged
fix: deduplicate gain/loss JE creation for journals as payment #36911
ruthra-kumar
merged 5 commits into
frappe:develop
from
ruthra-kumar:deduplicate_gain_loss_journal_creation
Sep 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
September 2, 2023 06:30
github-actions
bot
added
accounts
needs-tests
This PR needs automated unit-tests.
labels
Sep 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #36911 +/- ##
===========================================
+ Coverage 65.42% 65.55% +0.13%
===========================================
Files 794 795 +1
Lines 62194 62650 +456
===========================================
+ Hits 40692 41073 +381
- Misses 21502 21577 +75
|
ruthra-kumar
force-pushed
the
deduplicate_gain_loss_journal_creation
branch
from
September 2, 2023 08:01
e020d95
to
cb6da6e
Compare
ruthra-kumar
added a commit
that referenced
this pull request
Sep 3, 2023
…-36911 fix: deduplicate gain/loss JE creation for journals as payment (backport #36911)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconciling Journal Entry to Invoices should not create duplicate gain/loss JE.
For Gain/Loss JE's, use payment's cost center, if company default is unset.
fixes: #36873 (comment)