fix: fetch currency in discount accounting SI #36889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using Discount Accounting, if a Sales Invoice is created using a different currency instead of the default currency for that company, the GL entries created consider the SI currency for the discount account but the company default currency for all other accounts. This leads to a mismatch in the total debit and total credit values and the SI cannot be submitted.
Solution
Use the
base_discount_amount
instead of thediscount_amount
in the GL entry for Discount Accounting.Closes #36529