Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show customer name for naming series in process soa #36843

Merged
merged 5 commits into from
Sep 10, 2023

Conversation

GursheenK
Copy link
Member

Problem

  • In Process Statement of Accounts - GL and AR the default subject and body of the email used the name field for specifying the customer. However, in cases where the name of the Customer document is different from the customer_name field (eg: when naming series is used for Customer doctype), the subject and body of the email show the document name instead of the customer name.
  • For the AR report, the html template fetches the name field instead of the customer_name.
  • AR report PDF does not show the Letterhead and Terms.

Solution

  • Used customer_name field instead of name wherever necessary.
  • Added HTML code for rendering Letterhead and Terms in AR Report.

Notes for Reviewer

As mentioned in the issue, there was a need to use the Subject as the PDF name before sending the report PDF in the email. Have added an extra field for specifying the PDF name format in Email Settings to keep things general. Please mention if a different approach can be used here.


Screenshot 2023-08-28 at 1 32 18 PM

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #36843 (060da2c) into develop (91927f2) will increase coverage by 0.21%.
Report is 31 commits behind head on develop.
The diff coverage is 77.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36843      +/-   ##
===========================================
+ Coverage    65.39%   65.61%   +0.21%     
===========================================
  Files          794      794              
  Lines        62122    62189      +67     
===========================================
+ Hits         40626    40805     +179     
+ Misses       21496    21384     -112     
Files Changed Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py 58.85% <77.77%> (+58.85%) ⬆️

... and 14 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Sep 10, 2023
@deepeshgarg007 deepeshgarg007 merged commit b34c03d into frappe:develop Sep 10, 2023
13 checks passed
deepeshgarg007 added a commit that referenced this pull request Sep 11, 2023
…-36843

fix: show customer name for naming series in process soa (#36843)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants