Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create portal user for customer from shopping cart #36745

Merged

Conversation

git-avc
Copy link
Contributor

@git-avc git-avc commented Aug 21, 2023

fix #36744

From shopping cart, customer is created when order/quotation is placed. But customer don't connect with user.
This PR adds user to portal_user child on customer form.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #36745 (41a5119) into develop (a34cb8a) will increase coverage by 0.23%.
Report is 21 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36745      +/-   ##
===========================================
+ Coverage    64.94%   65.18%   +0.23%     
===========================================
  Files          792      792              
  Lines        61821    61836      +15     
===========================================
+ Hits         40151    40306     +155     
+ Misses       21670    21530     -140     
Files Changed Coverage Δ
erpnext/e_commerce/shopping_cart/cart.py 52.39% <100.00%> (+0.12%) ⬆️

... and 13 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit fa2e5d5 into frappe:develop Aug 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer can't access to quotations/orders created from shopping cart
2 participants