Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include gain/loss journal in AR/AP reports #36728

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 21, 2023

Exchange Gain/Loss journal created through Exchange Rate Revaluation is not fetched on Accounts Receivable Report. This leads to outstanding amount being reported even though total debit matches total credit in ledger.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #36728 (e3104f1) into develop (8601e5b) will increase coverage by 0.11%.
Report is 32 commits behind head on develop.
The diff coverage is 89.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36728      +/-   ##
===========================================
+ Coverage    64.82%   64.94%   +0.11%     
===========================================
  Files          792      792              
  Lines        61798    61829      +31     
===========================================
+ Hits         40063    40157      +94     
+ Misses       21735    21672      -63     
Files Changed Coverage Δ
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 79.80% <ø> (ø)
.../report/accounts_receivable/accounts_receivable.py 71.11% <ø> (ø)
erpnext/accounts/utils.py 73.98% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.50% <87.50%> (-0.22%) ⬇️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 73.37% <100.00%> (+0.09%) ⬆️
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.15% <100.00%> (-0.06%) ⬇️

... and 8 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 06f86ad into frappe:develop Aug 21, 2023
15 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 21, 2023
ruthra-kumar added a commit that referenced this pull request Aug 21, 2023
…-36728

fix: include gain/loss journal in AR/AP reports (backport #36728)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant