-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make offsetting entry for acc dimensions in general ledger #36149
Merged
deepeshgarg007
merged 15 commits into
frappe:develop
from
GursheenK:balancing-accounting-dimensions
Jul 29, 2023
Merged
fix: make offsetting entry for acc dimensions in general ledger #36149
deepeshgarg007
merged 15 commits into
frappe:develop
from
GursheenK:balancing-accounting-dimensions
Jul 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36149 +/- ##
===========================================
+ Coverage 64.33% 64.69% +0.35%
===========================================
Files 786 786
Lines 61078 61111 +33
===========================================
+ Hits 39295 39536 +241
+ Misses 21783 21575 -208
|
GursheenK
changed the title
fix: make offsetting entry for acc dimensions in JV
fix: make offsetting entry for acc dimensions in general ledger
Jul 17, 2023
deepeshgarg007
added a commit
that referenced
this pull request
Aug 21, 2023
…-36149 fix: make offsetting entry for acc dimensions in general ledger (#36149)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When multiple GL entries are posted against documents like Invoices, Journal Entries, Payment Entries, etc. with different values for one or multiple accounting dimensions, the accounts are balanced and show the correct values. However, when these entries are filtered using the accounting dimensions, the Debit and Credit values do not match because the corresponding entry can have a different value for the same accounting dimension.
Solution
An offsetting entry is posted for each accounting dimension that has more than one value in the gl_map. An option to automatically make an offsetting entry is added to the Accounting Dimension document. When enabled, the user has to choose an offsetting account which will be used for the extra entries.
Example
For a Journal Entry where
₹1000
is transferred from Branch Delhi to Branch Mumbai, only 2 GL entries were made. In such a case the Trial Balance Report filtered using the Accounting Dimension Branch is not balanced.Now, if we enable the Automatically post balancing accounting entry for the Accounting Dimension Branch and select an Offsetting Account from the Accounting Dimension Doctype, for a Journal Entry where
₹1000
is transferred from Branch Delhi to Branch Mumbai, 4 GL entries are made -The Trial Balance is now balanced whenever Journal Entries are made and filtered using Accounting Dimensions.