Merge pull request #183 from RitvikSardana/develop-ritvik-discount-type

fix: remove translation call from hooks.py and convert discount to float while validating discount
frappe · Jan 26, 2024 · 7f77de8 · 7f77de8
2 parents e7af91a + 15907db
commit 7f77de8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/education/education/doctype/fee_structure/fee_structure.py b/education/education/doctype/fee_structure/fee_structure.py
@@ -25,7 +25,7 @@ def calculate_total(self):
 
 	def validate_discount(self):
 		for component in self.components:
-			if component.discount > 100:
+			if flt(component.discount) > 100:
 				frappe.throw(
 					_("Discount cannot be greater than 100%  in row {0}").format(component.idx)
 				)

diff --git a/education/hooks.py b/education/hooks.py
@@ -45,7 +45,7 @@
 
 standard_portal_menu_items = [
 	{
-		"title": _("Admission"),
+		"title": "Admission",
 		"route": "/admissions",
 		"reference_doctype": "Student Admission",
 		"role": "Student",