Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Link Field & Contact linking with deal & organization #26

Merged
merged 51 commits into from
Nov 16, 2023
Merged

feat: Link Field & Contact linking with deal & organization #26

merged 51 commits into from
Nov 16, 2023

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Nov 9, 2023 •
edited
Loading

  1. Added Link Field which shows options based on the doctype passed
  2. Using Link Field everywhere required
  3. Also Implemented a way to add new doc from the Link Field dropdown
  4. Added a contact section in deal to add/remove or create contact, set primary contact
  5. Also handled contact creation if a lead is converted to deal
  6. Removed contact from lead (Will have to think if required)
  7. Contact with email_ids & phone_nos, set primary email/phone

And many minor refactors and UI & UX enhancements & fixes

@shariquerik
fix: removed contact creation/updation code from lead
8f25684
@shariquerik
fix: router to contact after creation
86fb7db
@shariquerik
fix: router to contacts after deletion
fd7bf74
@shariquerik
fix: removed unused imports
4000dfa
@shariquerik
fix: create contact after lead is converted
d01b3e3
@shariquerik
refactor: better way to update field/field in lead/deal
2d2bca1
@shariquerik
fix: get contacts along with email_ids & phone_nos
602a71c
@shariquerik
fix: changed frappeui dropdown component to handle footer (for now ma…
d2e4d36 
…de a copy)
@shariquerik
fix: create new email/phone no using dropdown also show all emails/ph…
67f38c9 
…ones
@shariquerik
fix: include contacts with deal
f1f6c91
@shariquerik
fix: added contacts section in deal
5cc0430
@shariquerik
chore: spacing fixes
7209779
@shariquerik
fix: Add new organization button in lead organization autocomplete
1cb017a
@shariquerik
feat: add/remove contact in deal
50fceef
@shariquerik
fix: create new contact from deals add contact
d3d9caa
@shariquerik
fix: redirect to organization & deal was not working from contact page
c40e307
@shariquerik
fix: redirect to deal was not working from organization page
4371a27
@shariquerik
fix: after converting to deal add contact & deal owner
d297f04
@shariquerik
fix: set contact as primary backend logic
36f4dde
@shariquerik
feat: set contact as primary from UI
d408d06
@shariquerik
fix: create new email/phone if contact doesn't have any
1203990
@shariquerik
fix: made industry readonly & removed job title from organization
2f6b55e
@shariquerik
fix: remove selectable from contact/organizations lead/deal/contact l…
289bc4d 
…istview
@shariquerik
feat: Link component to render any link field with options
4be5c18
@shariquerik
fix: updated autocomplete to handle variant & size
ce9477d
@shariquerik
fix: added more organization fields
9148163
@shariquerik
fix: return value as string not object
929c0e4
@shariquerik
fix: load all organization fields
230ecae
@shariquerik
fix: show industry & revenue in details section
ca036bc
@shariquerik
fix: update LeadListView/DealListView
e6ce52f
@shariquerik
chore: change only if value is there
eadea3e
@shariquerik
fix: Link control was showing only 20 records
8224af8
@shariquerik
fix: added Link Control in contact modal for organization
e748c55
@shariquerik
fix: also replaced Salutation with Link field
61fa0eb
@shariquerik
fix: added hooks to validate contact before save
f5e3b81
@shariquerik
fix: set emails/phones table on contact create
f71525f
@shariquerik
chore: removed unused code
7bd276c
@shariquerik
fix: also handle value+change along with v-model
21cc553
@shariquerik
fix: replaced salutation & organization with Link field in contact
cc1657e
@shariquerik
chore: code formatting
179c670
@shariquerik
fix: allow slots in link field
ac1a20e
@shariquerik
fix: replaced salutation, source & organization with link field in lead
5abf460
@shariquerik
fix: replaced organization & add contact autocomplete with link field
dc5b206
@shariquerik
fix: debounce & cache the link options
aa9eafd
@shariquerik
revert: removed storage cache from link field
318a497
@shariquerik
fix: get linked deals in contact
e286551
@shariquerik
refactor: get link options
f0fae04
@shariquerik
feat: filterable autocomplete
e9bbd2f
@shariquerik
fix: not able to redirect after creating org from lead/deal
c843f68
@shariquerik
fix: moved create one btn from slot to Link component
10a37c6
@shariquerik
fix: create organization and set from new lead/deal dialog
1caaa89
@shariquerik shariquerik changed the title feat: Contact linking feat: Link Field & Contact linking with deal & organization Nov 16, 2023
@shariquerik shariquerik merged commit 6180899 into frappe:develop Nov 16, 2023
1 check passed
@shariquerik shariquerik deleted the contact-linking branch November 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shariquerik