feat: allow nginx apply mtls for a specific path #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this change to work on the bench, it is necessary to analyze the frappe pull request:
frappe/frappe#28125
Currently, some integrations that work with sensitive data are required to use mTLS, for example integration with credit card companies, banks, fintechs...
mTLS consists of validating whether the client is using a valid certificate to access the service, but it is a two-way validation, in this case it validates the client and server certificates.
Requests to the URL "/api/secure/{methodname}" will require mandatory validation at both ends of the digital certificate, thus applying mTLS validation by nginx.
ssl_verify_client optional was chosen because this method does not impact other URLs.