Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting redis WARN and supervisor ERROR while bench init command #1607

Closed
yknevenky opened this issue Dec 17, 2024 · 5 comments · Fixed by #1614
Closed

Getting redis WARN and supervisor ERROR while bench init command #1607

yknevenky opened this issue Dec 17, 2024 · 5 comments · Fixed by #1614
Labels
bug

Comments

@yknevenky
Copy link

Description of the issue

Context information (for bug reports)

Output of bench version

5.23.0

Steps to reproduce the issue

  1. bench init library-bench

Observed result

$ sudo supervisorctl restart frappe:
frappe: ERROR (no such group)
frappe: ERROR (no such group)
WARN: restarting supervisor group frappe: failed. Use bench restart to retry.

DONE Total Build Time: 14.695s

WARN Cannot connect to redis_cache to update assets_json
WARN Cannot connect to redis_cache to update assets_json
WARN Cannot connect to redis_cache to update assets_json

Expected result

No WARN and ERROR

Stacktrace / full error message

bench init library_bench
Setting Up Environment
$ python3 -m venv env
$ /home/noshack/assetplus/library_bench/env/bin/python -m pip install --quiet --upgrade pip
$ /home/noshack/assetplus/library_bench/env/bin/python -m pip install --quiet wheel
Getting frappe
$ git clone https://github.com/frappe/frappe.git  --depth 1 --origin upstream
Cloning into 'frappe'...
remote: Enumerating objects: 3433, done.
remote: Counting objects: 100% (3433/3433), done.
remote: Compressing objects: 100% (2984/2984), done.
remote: Total 3433 (delta 527), reused 1612 (delta 349), pack-reused 0 (from 0)
Receiving objects: 100% (3433/3433), 16.71 MiB | 7.60 MiB/s, done.
Resolving deltas: 100% (527/527), done.
Installing frappe
$ /home/noshack/assetplus/library_bench/env/bin/python -m pip install --quiet --upgrade -e /home/noshack/assetplus/library_bench/apps/frappe 
$ yarn install --check-files
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > @frappe/esbuild-plugin-postcss2@0.1.3" has unmet peer dependency "less@^4.x".
warning " > @frappe/esbuild-plugin-postcss2@0.1.3" has unmet peer dependency "stylus@^0.x".
warning " > @vue/component-compiler@4.2.4" has unmet peer dependency "vue-template-compiler@*".
[5/5] Building fresh packages...
$ cd billing && yarn install
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
warning Pattern ["strip-ansi@^6.0.1"] is trying to unpack in the same destination "/home/noshack/.cache/yarn/v6/npm-strip-ansi-cjs-6.0.1-9e26c63d30f53443e9489495b2105d37b67a85d9-integrity/node_modules/strip-ansi-cjs" as pattern ["strip-ansi-cjs@npm:strip-ansi@^6.0.1"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["string-width@^4.1.0"] is trying to unpack in the same destination "/home/noshack/.cache/yarn/v6/npm-string-width-cjs-4.2.3-269c7117d27b05ad2e536830a8ec895ef9c6d010-integrity/node_modules/string-width-cjs" as pattern ["string-width-cjs@npm:string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["strip-ansi@^6.0.0"] is trying to unpack in the same destination "/home/noshack/.cache/yarn/v6/npm-strip-ansi-cjs-6.0.1-9e26c63d30f53443e9489495b2105d37b67a85d9-integrity/node_modules/strip-ansi-cjs" as pattern ["strip-ansi-cjs@npm:strip-ansi@^6.0.1"]. This could result in non-deterministic behavior, skipping.
[3/4] Linking dependencies...
warning "frappe-ui > @tiptap/extension-color@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-highlight@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-image@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-link@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-mention@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-placeholder@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-table@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-table-cell@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-table-header@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-table-row@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-text-align@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-text-style@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/extension-typography@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/suggestion@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/vue-3@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/vue-3 > @tiptap/extension-bubble-menu@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
warning "frappe-ui > @tiptap/vue-3 > @tiptap/extension-floating-menu@2.9.1" has unmet peer dependency "@tiptap/core@^2.7.0".
[4/4] Building fresh packages...
Done in 2.30s.
Done in 7.75s.
Found existing apps updating states...
[sudo] password for noshack: 
$ sudo supervisorctl restart frappe:
frappe: ERROR (no such group)
frappe: ERROR (no such group)
WARN: restarting supervisor group `frappe:` failed. Use `bench restart` to retry.
$ bench build
Assets for Commit ea49c2500cfe4674816101e2308f19a5dfc94570 don't exist
✔ Application Assets Linked                                                                                                                                                                   


yarn run v1.22.22
$ node esbuild --production --run-build-command
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
File                                                        Size

frappe/dist/js/
├─ billing.bundle.AFTRQ3D5.js                               4.00 Kb
├─ bootstrap-4-web.bundle.FOZOVELL.js                       1.73 Kb
├─ calendar.bundle.4A4YITIU.js                              264.60 Kb
├─ controls.bundle.XYVEQIFK.js                              1241.65 Kb
├─ data_import_tools.bundle.RI2ELQ2X.js                     126.59 Kb
├─ desk.bundle.4HH6PEZI.js                                  1098.23 Kb
├─ dialog.bundle.A5ROBMXH.js                                58.41 Kb
├─ form.bundle.PVC3VYTQ.js                                  172.94 Kb
├─ frappe-web.bundle.CTKVRAH6.js                            832.19 Kb
├─ libs.bundle.TIV7ZGVY.js                                  556.25 Kb
├─ list.bundle.2NI4EHUJ.js                                  199.98 Kb
├─ logtypes.bundle.5KO3ZOOI.js                              0.72 Kb
├─ onboarding_tours.bundle.RAUR6X4Z.js                      7.60 Kb
├─ photoswipe.bundle.YSXZQA64.js                            60.50 Kb
├─ report.bundle.2OFYCWWJ.js                                200.07 Kb
├─ sentry.bundle.AX44GVWW.js                                74.42 Kb
├─ telemetry.bundle.LKEZCADB.js                             2.59 Kb
├─ user_profile_controller.bundle.TPZWXYWN.js               11.97 Kb
├─ video_player.bundle.DUYYLSFO.js                          120.67 Kb
├─ web_form.bundle.3HTEMKQ2.js                              1435.02 Kb
├─ form_builder.bundle.NZRZTLKL.js                          799.92 Kb
├─ form_builder.bundle.AD73Q2Q5.css                         23.22 Kb
├─ print_format_builder.bundle.YIT4AB6Y.js                  685.26 Kb
├─ print_format_builder.bundle.JDLOTBZ4.css                 5.60 Kb
├─ workflow_builder.bundle.M6CBD574.js                      352.33 Kb
├─ workflow_builder.bundle.6X2GKTT3.css                     11.02 Kb
├─ build_events.bundle.HP5QRMOA.js                          105.71 Kb
├─ build_events.bundle.FNDVFDQA.css                         1.29 Kb
├─ file_uploader.bundle.QIJE75N7.js                         202.29 Kb
├─ file_uploader.bundle.3W3D2ACS.css                        6.53 Kb
└─ kanban_board.bundle.7VUNYA4J.js                          578.28 Kb

frappe/dist/css/
├─ desk.bundle.RUV3V4PO.css                                 593.30 Kb
├─ email.bundle.ZMGNX5C2.css                                5.97 Kb
├─ login.bundle.WFWDV5QW.css                                32.54 Kb
├─ print.bundle.BGJDXBE2.css                                203.75 Kb
├─ print_format.bundle.G34JSYSN.css                         186.31 Kb
├─ report.bundle.2UTF5NAO.css                               5.33 Kb
├─ web_form.bundle.67UEQYW5.css                             14.69 Kb
└─ website.bundle.G3H7Z4KP.css                              449.26 Kb

frappe/dist/css-rtl/
├─ desk.bundle.2TTTWGEB.css                                 593.80 Kb
├─ email.bundle.6G4SLOY7.css                                5.98 Kb
├─ login.bundle.XHP52CV5.css                                32.54 Kb
├─ print.bundle.TJN42VAO.css                                203.91 Kb
├─ print_format.bundle.RMITBMTD.css                         186.44 Kb
├─ report.bundle.EYJZ2Y7C.css                               5.33 Kb
├─ web_form.bundle.DUZHIRKN.css                             14.68 Kb
└─ website.bundle.FOS4VAH4.css                              449.43 Kb

 DONE  Total Build Time: 14.695s

 WARN  Cannot connect to redis_cache to update assets_json
 WARN  Cannot connect to redis_cache to update assets_json
 WARN  Cannot connect to redis_cache to update assets_json
Done in 15.48s.
yarn run v1.22.22
$ vite build --base=/assets/frappe/billing/ && yarn copy-html-entry
vite v4.5.5 building for production...
transforming (172) node_modules/@tiptap/extension-text-style/dist/index.js
Inter-DisplayRegular.woff2?v=3.19 referenced in /home/noshack/assetplus/library_bench/apps/frappe/billing/src/index.css didn't resolve at build time, it will remain unchanged to be resolved at runtime
✓ 492 modules transformed.
../frappe/public/billing/index.html                                                          0.94 kB │ gzip:   0.47 kB
../frappe/public/billing/assets/Inter-Regular-c342b1b7.woff2                               100.12 kB
../frappe/public/billing/assets/Inter-Regular-edd1deaf.woff2                               100.79 kB
../frappe/public/billing/assets/Inter-Thin-914c3fab.woff2                                  101.16 kB
../frappe/public/billing/assets/Inter-Thin-918c5cbe.woff2                                  101.41 kB
../frappe/public/billing/assets/Inter-DisplayBlack-b1d4e33d.woff2                          101.92 kB
../frappe/public/billing/assets/Inter-DisplayThin-b64c173b.woff2                           102.15 kB
../frappe/public/billing/assets/Inter-ExtraLight-25a4db7c.woff2                            102.87 kB
../frappe/public/billing/assets/Inter-Light-211445a8.woff2                                 103.27 kB
../frappe/public/billing/assets/Inter-Black-05e55dd7.woff2                                 103.59 kB
../frappe/public/billing/assets/Inter-Black-bc2198e0.woff2                                 104.52 kB
../frappe/public/billing/assets/Inter-ExtraBold-8a72efb6.woff2                             104.99 kB
../frappe/public/billing/assets/Inter-Bold-1dc41a58.woff2                                  105.21 kB
../frappe/public/billing/assets/Inter-Medium-24fb6e39.woff2                                105.22 kB
../frappe/public/billing/assets/Inter-DisplayLight-e40a858d.woff2                          105.34 kB
../frappe/public/billing/assets/Inter-DisplayExtraBold-b7cc680a.woff2                      105.36 kB
../frappe/public/billing/assets/Inter-DisplayMedium-12a4a358.woff2                         105.38 kB
../frappe/public/billing/assets/Inter-SemiBold-51419407.woff2                              105.40 kB
../frappe/public/billing/assets/Inter-DisplaySemiBold-856fcb49.woff2                       105.56 kB
../frappe/public/billing/assets/Inter-DisplayBold-d9bf35ac.woff2                           105.57 kB
../frappe/public/billing/assets/Inter-Light-87ed65f8.woff2                                 105.64 kB
../frappe/public/billing/assets/Inter-DisplayExtraLight-32095132.woff2                     105.87 kB
../frappe/public/billing/assets/Inter-ExtraLight-4c337585.woff2                            105.96 kB
../frappe/public/billing/assets/Inter-DisplayItalic-938db435.woff2                         106.12 kB
../frappe/public/billing/assets/Inter-Italic-dd31ea31.woff2                                106.55 kB
../frappe/public/billing/assets/Inter-ThinItalic-382fab25.woff2                            106.64 kB
../frappe/public/billing/assets/Inter-Medium-a4e1e7e6.woff2                                106.72 kB
../frappe/public/billing/assets/Inter-SemiBold-af44b8a2.woff2                              107.23 kB
../frappe/public/billing/assets/Inter-DisplayBlackItalic-d561e8dd.woff2                    107.28 kB
../frappe/public/billing/assets/Inter-Bold-2efd8e3c.woff2                                  107.40 kB
../frappe/public/billing/assets/Inter-DisplayThinItalic-b70f1c61.woff2                     107.44 kB
../frappe/public/billing/assets/Inter-ThinItalic-a3279f0a.woff2                            107.50 kB
../frappe/public/billing/assets/Inter-Italic-950174d1.woff2                                107.51 kB
../frappe/public/billing/assets/Inter-ExtraBold-74e72c6b.woff2                             107.55 kB
../frappe/public/billing/assets/Inter-LightItalic-9ea2db78.woff2                           108.56 kB
../frappe/public/billing/assets/Inter-BlackItalic-4ff7db4a.woff2                           108.59 kB
../frappe/public/billing/assets/Inter-ExtraLightItalic-f0df46d0.woff2                      109.00 kB
../frappe/public/billing/assets/Inter-BlackItalic-1cb529a7.woff2                           109.90 kB
../frappe/public/billing/assets/Inter-DisplayBoldItalic-fef00c57.woff2                     110.20 kB
../frappe/public/billing/assets/Inter-DisplaySemiBoldItalic-5e57e1d2.woff2                 110.39 kB
../frappe/public/billing/assets/Inter-DisplayMediumItalic-8968b5ab.woff2                   110.46 kB
../frappe/public/billing/assets/Inter-BoldItalic-dc0d4194.woff2                            110.52 kB
../frappe/public/billing/assets/Inter-ExtraBoldItalic-38e71f7c.woff2                       110.52 kB
../frappe/public/billing/assets/Inter-DisplayLightItalic-151e9a11.woff2                    110.56 kB
../frappe/public/billing/assets/Inter-SemiBoldItalic-daa7095c.woff2                        110.64 kB
../frappe/public/billing/assets/Inter-DisplayExtraBoldItalic-e5a5984a.woff2                110.82 kB
../frappe/public/billing/assets/Inter-MediumItalic-a2db9bea.woff2                          110.82 kB
../frappe/public/billing/assets/Inter-DisplayExtraLightItalic-8eeb78f4.woff2               111.11 kB
../frappe/public/billing/assets/Inter-LightItalic-5b94e337.woff2                           111.97 kB
../frappe/public/billing/assets/Inter-ExtraLightItalic-7b39e865.woff2                      112.06 kB
../frappe/public/billing/assets/Inter-MediumItalic-d4a7f5d9.woff2                          112.50 kB
../frappe/public/billing/assets/Inter-SemiBoldItalic-a4f92da5.woff2                        112.55 kB
../frappe/public/billing/assets/Inter-BoldItalic-f528d863.woff2                            112.58 kB
../frappe/public/billing/assets/Inter-ExtraBoldItalic-2abc7ab1.woff2                       112.88 kB
../frappe/public/billing/assets/Inter-Regular-b825f1bc.woff                                134.65 kB
../frappe/public/billing/assets/Inter-Thin-2198e9fb.woff                                   136.95 kB
../frappe/public/billing/assets/Inter-Black-9c79713b.woff                                  140.04 kB
../frappe/public/billing/assets/Inter-Light-319f53ba.woff                                  141.53 kB
../frappe/public/billing/assets/Inter-ExtraLight-1c06ef44.woff                             141.86 kB
../frappe/public/billing/assets/Inter-Italic-b0b21adf.woff                                 142.74 kB
../frappe/public/billing/assets/Inter-Medium-f500bbb9.woff                                 142.84 kB
../frappe/public/billing/assets/Inter-SemiBold-3041a990.woff                               143.25 kB
../frappe/public/billing/assets/Inter-ExtraBold-585b4ce1.woff                              143.55 kB
../frappe/public/billing/assets/Inter-Bold-2b828bef.woff                                   143.71 kB
../frappe/public/billing/assets/Inter-ThinItalic-f53f21de.woff                             144.41 kB
../frappe/public/billing/assets/Inter-BlackItalic-7ecbf9fa.woff                            145.92 kB
../frappe/public/billing/assets/Inter-LightItalic-289a60bc.woff                            148.44 kB
../frappe/public/billing/assets/Inter-ExtraLightItalic-0e5667b1.woff                       148.69 kB
../frappe/public/billing/assets/Inter-MediumItalic-d06751dd.woff                           149.18 kB
../frappe/public/billing/assets/Inter-ExtraBoldItalic-b87f7d97.woff                        149.20 kB
../frappe/public/billing/assets/Inter-SemiBoldItalic-5ce565c8.woff                         149.28 kB
../frappe/public/billing/assets/Inter-BoldItalic-8bc8e0ff.woff                             149.42 kB
../frappe/public/billing/assets/Inter.var-d30c3bd0.woff2                                   264.24 kB
../frappe/public/billing/assets/Inter-Italic.var-d9f448e3.woff2                            297.27 kB
../frappe/public/billing/assets/index-f8d75c6e.css                                       1,366.29 kB │ gzip: 142.23 kB
../frappe/public/billing/assets/AddCardModal-3c9bafc7.js                                     0.90 kB │ gzip:   0.58 kB │ map:     1.07 kB
../frappe/public/billing/assets/Invoices-00ce0bd8.js                                         3.87 kB │ gzip:   1.81 kB │ map:     9.03 kB
../frappe/public/billing/assets/Cards-7955ca22.js                                            5.01 kB │ gzip:   2.24 kB │ map:     9.75 kB
../frappe/public/billing/assets/ListView-f81a1206.js                                        11.99 kB │ gzip:   4.12 kB │ map:    24.59 kB
../frappe/public/billing/assets/Plans-9b44f50a.js                                           14.74 kB │ gzip:   5.70 kB │ map:    34.10 kB
../frappe/public/billing/assets/Overview-23ab5211.js                                        17.55 kB │ gzip:   5.74 kB │ map:    30.82 kB
../frappe/public/billing/assets/BillingDetails-71e8e074.js                                  18.13 kB │ gzip:   8.01 kB │ map:    28.07 kB
../frappe/public/billing/assets/CardForm-5ad2b621.js                                        42.00 kB │ gzip:  15.74 kB │ map:    68.21 kB
../frappe/public/billing/assets/Tooltip.vue_vue_type_script_setup_true_lang-602230f1.js     57.63 kB │ gzip:  20.04 kB │ map: 1,072.42 kB
../frappe/public/billing/assets/index-aee75141.js                                          764.18 kB │ gzip: 247.51 kB │ map: 3,716.84 kB

(!) Some chunks are larger than 500 kBs after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 16.88s
$ cp ../frappe/public/billing/index.html ../frappe/www/billing.html
Done in 17.68s.
Compiling translations for frappe
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/hu/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/tr/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/sv/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/id/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/ar/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/af/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/it/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/es/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/pl/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/zh_TW/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/vi/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/pt/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/fr/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/eo/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/de/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/zh/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/nl/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/fa/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/ru/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/fi/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/pt_BR/LC_MESSAGES/frappe.mo
MO file created at /home/noshack/assetplus/library_bench/sites/assets/locale/bs/LC_MESSAGES/frappe.mo
SUCCESS: Bench library_bench initialized

Additional information

Linux Ubuntu
@yknevenky yknevenky added the bug label Dec 17, 2024
@akhilnarang akhilnarang transferred this issue from frappe/frappe Dec 18, 2024
@yknevenky
Copy link
Author

yknevenky commented Jan 7, 2025 •
edited
Loading

@akhilnarang Any update on this? or at least give us some kind of explanations that we can be aware of. I understand you guys trying your best to address the issues, I totally appreciate your efforts on this. It would help us a lot better if you guys give us some kind of explanations.

@akhilnarang
Copy link
Member

Hey,

Both the warnings are fine and can be ignored.
Will work on something to avoid them popping up.

akhilnarang added a commit to akhilnarang/bench that referenced this issue Jan 7, 2025
@akhilnarang
fix: check whether supervisorctl exists before trying to restart
01a3bf4 
Resolves frappe#1607

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang mentioned this issue Jan 7, 2025
Merged
@akhilnarang
Copy link
Member

@yknevenky I've fixed it for the cases where supervisorctl is not installed.

In your case, you do have it installed, so it will try to restart, and fail if its not being used, like your current case.

@yknevenky
Copy link
Author

I am still kind of confused. But what's the role of supervisor here? and what does WARN Cannot connect to redis_cache to update assets_json this mean? Like why Redis needs to update assets_json, what does it contain? Because you mentioned both the warnings are fine. But I need to know when these warnings are not okay to have. Also I am trying to write a blog on the Frappe and stuff as I learn. So explaining this here, would also make me blog it better when I blog it.

Basically I am trying to understand the things that are happening in the bench init command. Please help me with this. Thank you so much for your efforts @akhilnarang .

sudo supervisorctl restart frappe:
frappe: ERROR (no such group)
frappe: ERROR (no such group)
WARN: restarting supervisor group frappe: failed. Use bench restart to retry.

WARN Cannot connect to redis_cache to update assets_json
WARN Cannot connect to redis_cache to update assets_json
WARN Cannot connect to redis_cache to update assets_json

@akhilnarang
Copy link
Member

@yknevenky supervisor would be used in production setups, so by default when any frappe app is installed, we restart the bench, if your system has supervisor we try to restart the relevant supervisor groups.

Regarding the other warning, it comes from here: https://github.com/frappe/frappe/blob/develop/esbuild/esbuild.js#L481

When a site is running normal, redis will be running and we can use it for caching. During bench init redis isn't available, hence the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check whether supervisorctl exists before trying to restart akhilnarang/bench
2 participants
@akhilnarang @yknevenky