Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing some comments #16

Conversation

pfs
Copy link

@pfs pfs commented Jun 26, 2020

No description provided.

pfs added 2 commits June 26, 2020 10:24
cms-sw#30422 (comment) changed comment in the code, the function specializes, does not override in practice

cms-sw#30422 (comment) changed to const

cms-sw#30422 (comment) done

cms-sw#30422 (comment) the unordered_map adds some non-negligible extra mem to the process. We checked that the std::map will still perform faster per event than re-computing every single event as we don't need to query anywhere the map (find, count ,etc.) , just need to access it to retrieve the required values

cms-sw#30422 (comment) defined a new type hgc_digi::FEPulseShape in HGCFEElectronics.h

cms-sw#30422 (comment) +
cms-sw#30422 (comment) +
cms-sw#30422 (comment) +
cms-sw#30422 (comment) changed accordingly
@franzoni
Copy link
Owner

thanks Pedro!

@franzoni franzoni merged commit 97f017e into franzoni:hgcal_eol_pulse_update_112X_bis Jun 26, 2020
@pfs pfs deleted the hgcal_eol_pulse_update_112X_bis branch November 18, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants