Prevent race on applications quitting whilst save jobs are in process #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an application calls quit or closes all windows we still want to finish saving the password. Qt provides a mechanism to defer the exit whilst jobs are active. This brings us in line with KDE's KJob. Note this change can cause a niche behavioural change with QCoreApplication applications that incorrectly have with quit loop enabled and use the main event loop so should probably not be backported.
|
Wouldn't this break when using Qtkeychain jobs outside the main thread? |
|
Good question. It would hold a lock on the application. holding a lock on the app (QCoreApplicationPrivate::ref) is thread safe. It won't break. But it doesn't protect the thread case, one could still kill a thread with an active job, though I would say that's the caller's responsibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application calls quit or closes all windows we still want to finish saving the password. Qt provides a mechanism to defer the exit whilst jobs are active.
This brings us in line with KDE's KJob.
Note this change can cause a niche behavioural change with QCoreApplication applications that incorrectly have with quit loop enabled and use the main event loop so should probably not be backported.